feat: add basic latency metrics #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
May 6, 2024
services/api/service.go
Outdated
| @@ -1552,6 +1564,7 @@ func (api *RelayAPI) handleGetPayload(w http.ResponseWriter, req *http.Request) | |||
| msNeededForPublishing = uint64(timeAfterPublish - timeBeforePublish) | |||
| log = log.WithField("timestampAfterPublishing", timeAfterPublish) | |||
| log.WithField("msNeededForPublishing", msNeededForPublishing).Info("block published through beacon node") | |||
| metrics.PublishBlockLatencyHistogram.Record(req.Context(), float64(timeAfterPublish-timeBeforePublish)) | |||
There was a problem hiding this comment.
why not use msNeededForPublishing?
There was a problem hiding this comment.
fair. updated accordingly.
avalonche
previously approved these changes
May 6, 2024
avalonche
approved these changes
May 7, 2024
metachris
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add basic latency metrics for
GetPayloadandPublishBlock.⛱ Motivation and Context
We want to be able to track those metrics per-instance as well as aggregate them across the whole service (running behind the load-balancer).
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md